fix-ready-prs

Source excerpt starting at line 1.

1---2name: fix-ready-prs3description: Inspect every open non-draft PR for CI failures and unresolved Cursor Bugbot findings, then fix them on the existing PR branches. Use when asked to check active PRs, triage ready PRs, fix CI, or address Bugbot comments.4metadata:5  internal: true6---7 8# Fix Ready PRs9 10Work through every **open, non-draft** pull request. Fix CI failures and11unresolved Bugbot findings on the existing PR branch. Do not open a new PR for12an existing one.13 14Drafts are out of scope unless the user names them.15 16## 1. Inventory17 18```bash19gh pr list --state open --limit 200 \20  --json number,title,isDraft,headRefName,headRepositoryOwner,isCrossRepository,url,mergeStateStatus21```22 23Keep only `isDraft == false`. Record number, branch, URL, and whether the head24is a fork (`isCrossRepository`).25 26## 2. Collect failures27 28For each ready PR, gather **current-head** CI and **unresolved** Bugbot threads.29Do not treat an in-progress check as green.30 31### CI32 33```bash34gh pr checks <n>35gh pr view <n> --json statusCheckRollup,headRefOid36```37 38Treat as a failure when a required or repo workflow check is `FAILURE`,39`TIMED_OUT`, `ACTION_REQUIRED`, or `CANCELLED` on the current head and has not40been superseded by a newer run.41 42Ignore:43 44- `SKIPPED` / `NEUTRAL`45- Netlify header/pages/redirect checks and canceled deploy previews46- Mintlify Deployment skips47- macOS/Windows/iOS jobs that this repo skips on pull requests48 49If a failing job has logs, pull them:50 51```bash52gh run view <run-id> --log-failed53```54 55If checks are still `IN_PROGRESS` / `pending`, wait until they finish or fail56before declaring the PR clean. Re-poll rather than guessing.57 58### Bugbot59 60Use review threads, not only the Bugbot check conclusion. A green Bugbot check61can still leave unresolved comments, and an older finding may already be62fixed.63 64GitHub returns `reviewThreads` oldest-first with no unresolved-only filter.65Page until `hasNextPage` is false. Do not stop at the first 50 threads.66 67```bash68after=""69while :; do70  if [ -n "$after" ]; then71    page=$(gh api graphql -f query="$THREADS_QUERY" -F n=<n> -F after="$after")72  else73    page=$(gh api graphql -f query="$THREADS_QUERY" -F n=<n>)74  fi75  echo "$page" | jq '.data.repository.pullRequest.reviewThreads.nodes[]'76  has_next=$(echo "$page" | jq -r '.data.repository.pullRequest.reviewThreads.pageInfo.hasNextPage')77  after=$(echo "$page" | jq -r '.data.repository.pullRequest.reviewThreads.pageInfo.endCursor')78  [ "$has_next" = true ] || break79done80```81 82`$THREADS_QUERY` is:83 84```graphql85query($n: Int!, $after: String) {86  repository(owner: "fastrepl", name: "anarlog") {87    pullRequest(number: $n) {88      reviewThreads(first: 50, after: $after) {89        pageInfo { hasNextPage endCursor }90        nodes {91          isResolved92          isOutdated93          comments(first: 5) {94            nodes { author { login } path line body }95          }96        }97      }98    }99  }100}101```102 103Fix a thread when:104 105- the author is `cursor` / `cursor[bot]`106- `isResolved` is false107- the comment is a Bugbot finding (`<!-- BUGBOT_BUG_ID:` or a severity heading)108- it still applies to the current head (`isOutdated` is false, or outdated but109  the same bug is still in the code)110 111Skip resolved threads and outdated findings whose code already changed.112 113Also paginate review comments in case Bugbot posted one that is not yet a114thread:115 116```bash117gh api --paginate repos/fastrepl/anarlog/pulls/<n>/comments118gh pr view <n> --comments119```120 121## 3. Fix on the PR branch122 123For each PR that has work, check out **that PR's head**, including fork heads:124 125```bash126gh pr checkout <n>127```128 129Do not `git fetch origin <headRefName>` or `git push origin <headRefName>`.130Fork PRs keep the branch on the contributor remote; `origin/<headRefName>` is131missing or is a different branch. Pushing to `origin` can create a stray132branch that is not the PR head.133 134Then:135 1361. Reproduce from the failing log or Bugbot location1372. Make the smallest change that fixes the failure or finding1383. Run the locally available checks from the CI workflows that the changed139   paths trigger (`AGENTS.md` pre-commit verification)1404. Commit on that branch (do not amend someone else's commit)1415. `git push` (uses the tracking remote from `gh pr checkout`)142 143If `gh pr checkout` or `git push` cannot update a fork, stop and report that.144Do not open a replacement PR on `origin`.145 146Do not bundle unrelated PR fixes onto one branch. Do not retarget or close PRs.147 148If a finding is a false positive, leave it. Do not resolve GitHub review149threads unless the user asked; the code change is the fix.150 151## 4. Recheck152 153After pushing, re-run the inventory for that PR. Confirm:154 155- new CI is running or green156- the previous failure is gone or replaced by a new run157- the Bugbot thread is outdated or will be re-reviewed on the new commit158 159If a new failure or finding appears, fix it too.160 161## 5. Report162 163Summarize every ready PR:164 165- clean (CI green, no unresolved Bugbot)166- waiting (checks still running)167- fixed (what changed, PR number)168- skipped draft169 170Do not merge.171